This repository was archived by the owner on Jan 27, 2021. It is now read-only.
Passed "token" param joinChannel method call#6
Open
utsavtiwary04 wants to merge 1 commit intoEkaanshArora:masterfrom
Open
Passed "token" param joinChannel method call#6utsavtiwary04 wants to merge 1 commit intoEkaanshArora:masterfrom
utsavtiwary04 wants to merge 1 commit intoEkaanshArora:masterfrom
Conversation
To allow a client to join the channel of a secure Agora app (one which has app certificate enabled, a token is needed)
Owner
|
Hey thanks for opening a PR, I think a better solution to this would be making the token param optional, the project should work without it as well. Can you make the change, will be happy to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow a client to join the channel of a secure Agora app (one which has app certificate enabled), a token is needed. The token can be generated here
https://console.agora.io/project/<proj-name>